◐ Shell
clean mode source ↗

sqlite: Fix missing ProgrammingError for parameter mismatch by ever0de · Pull Request #6104 · RustPython/RustPython

ever0de

Walkthrough

Adds bind-parameter-count validation to the Python sqlite3 wrapper: new Statement helper to query bind parameter count, early checks in Cursor.execute, and updated binding-sequence validation with clearer ProgrammingError messages. No public API signature changes. (43 words)

Changes

Cohort / File(s) Summary of changes
SQLite binding validation
stdlib/src/sqlite.rs		 Added a private helper on Statement to fetch the number of bind parameters; added early validation in Cursor.execute when no params are supplied but the statement requires some; reworked bind_parameters_sequence to compare expected vs supplied counts and raise ProgrammingError with clearer messages; preserved existing binding logic and public API signatures.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor PyCode as Python
  participant Cursor
  participant Statement
  participant SQLite

  PyCode->>Cursor: execute(sql, params?)
  Cursor->>Statement: prepare(sql)
  Cursor->>Statement: bind_parameter_count()
  Statement-->>Cursor: count

  alt no params supplied and count > 0
    Cursor-->>PyCode: ProgrammingError("uses {count}, and 0 were supplied")
  else params supplied
    Cursor->>Cursor: compare supplied_count vs count
    alt mismatch
      Cursor-->>PyCode: ProgrammingError("uses {count}, and {supplied} were supplied")
    else match
      Cursor->>Statement: bind(params)
      Statement->>SQLite: step()/execute
      SQLite-->>Cursor: result
      Cursor-->>PyCode: result/rows
    end
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • youknowone

Poem

Thump-thump, I count the pebbles in line,
Each little binding must match, or decline.
I hop and I check, with whiskers alert—
No extra carrots, no missing dessert.
Bind true, dear coder, and bytes will align. 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9722338 and a47ba75.

⛔ Files ignored due to path filters (1)
  • Lib/test/test_sqlite3/test_dbapi.py is excluded by !Lib/**
📒 Files selected for processing (1)
  • stdlib/src/sqlite.rs (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • stdlib/src/sqlite.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Check Rust code with rustfmt and clippy
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Ensure compilation on various targets
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.