Fix broken CI on windows by ShaharNaveh · Pull Request #6143 · RustPython/RustPython

ShaharNaveh

Recently our CI for windows started to fail. I ain't sure what's the root cause of it but it seems like it has to do with anything related to symlinks.

Anyway, this PR aims to mark the tests appropriately. I didn't update those tests to CPython 3.13.7 so we will have a clearer diff & can revert in case there's a deeper root cause that needs to be addressed

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (7)

Lib/test/test_dtrace.py is excluded by !Lib/**
Lib/test/test_genericpath.py is excluded by !Lib/**
Lib/test/test_ntpath.py is excluded by !Lib/**
Lib/test/test_py_compile.py is excluded by !Lib/**
Lib/test/test_shutil.py is excluded by !Lib/**
Lib/test/test_stat.py is excluded by !Lib/**
Lib/test/test_tarfile.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Alright, I did a bit of investigation. my conclusion is that github changed the windows-latest image from being windows-2022 to windows-2025.

@youknowone how should we proceed? should we merge this PR? or should we pin the CI to use windows-2022? or even add another runner so we will check both 2022 and 2025 (if we do it, our patches will need to be slightly different)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we actually fix the problems, but any fix is better than no fix