◐ Shell
clean mode source ↗

Revert "Pin CI image to `windows-2025`" by ShaharNaveh · Pull Request #6182 · RustPython/RustPython

youknowone

Walkthrough

Updated .github/workflows/ci.yaml to switch OS matrices to inline arrays and revert Windows runner labels from windows-2025 (with a TODO) to windows-latest across rust_tests jobs and snippets_cpython group. No logic or control-flow changes.

Changes

Cohort / File(s) Change summary
CI workflow matrix tweaks
\.github/workflows/ci.yaml		 Converted multi-line OS lists to inline arrays for macOS, Ubuntu, and Windows. Replaced windows-2025 references with windows-latest in rust_tests jobs and snippets_cpython group. No other edits.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Pin CI image to windows-2025 #6148 — Also modifies .github/workflows/ci.yaml matrices and Windows runner label; this PR reverts the runner from windows-2025 back to windows-latest.

Suggested reviewers

  • youknowone

Poem

I hop through YAML fields so bright,
Inline arrays aligned just right.
Windows shifts to “latest” breeze,
Mac and Ubuntu hop with ease.
No flows were changed, just tidy trails—
A rabbit’s CI tale, with cotton tails. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly identifies the primary change as reversing the earlier CI image pin to windows-2025 and aligns with the PR objectives without extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a6fda4 and 412fb7c.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-11T09:35:43.571Z 
Learnt from: ShaharNaveh
PR: RustPython/RustPython#5947
File: .github/workflows/ci.yaml:116-116
Timestamp: 2025-07-11T09:35:43.571Z
Learning: GitHub Actions timeout-minutes field supports expressions that evaluate to integers, such as `${{ contains(matrix.os, 'windows') && 40 || 30 }}`, which will conditionally set different timeout values based on the runner OS.

Applied to files:

  • .github/workflows/ci.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Check Rust code with rustfmt and clippy
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Ensure compilation on various targets
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Run rust tests (macos-latest)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.