Configure dependabot to ignore ruff updates by ShaharNaveh · Pull Request #6185 · RustPython/RustPython

ShaharNaveh

Walkthrough

Added a Dependabot ignore rule for Cargo deps matching ruff_*; bumped lexical-parse-float from 1.0.4 to 1.0.6 in compiler/literal/Cargo.toml; replaced a guarded build() call with build_unchecked() when constructing the lexical number format in compiler/literal/src/float.rs.

Changes

Cohort / File(s)	Summary
Dependabot configuration `.github/dependabot.yml`	Added an ignore rule for Cargo dependencies matching `ruff_*` with explanatory comments; no other schedule or ecosystem changes.
Compiler crate manifest `compiler/literal/Cargo.toml`	Bumped dependency `lexical-parse-float` from `1.0.4` to `1.0.6` (features: `format`) — no API or feature changes declared.
Float parsing logic `compiler/literal/src/float.rs`	Switched from a guarded `NumberFormatBuilder::build()` to `build_unchecked()` for the `PYTHON_STRING` format when calling `parse_inner`, removing runtime validation during format construction.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Caller as parse_inner caller
    participant Builder as NumberFormatBuilder
    participant Parser as lexical parse routine

    Note over Caller,Builder: Before
    Caller->>Builder: build() (validates)
    Builder-->>Caller: Result<Format, Error> (may Err)
    alt valid
        Caller->>Parser: parse_with_format(format)
        Parser-->>Caller: Result<f64, ParseError>
    else invalid
        Builder-->>Caller: Error
    end

    Note over Caller,Builder: After (changed)
    Caller->>Builder: build_unchecked() (no validation)
    Builder-->>Caller: Format (assumed valid)
    Caller->>Parser: parse_with_format(format)
    Parser-->>Caller: Result<f64, ParseError or UB-like behavior if format invalid)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I nibble code with careful paws,
A tiny hop to guard the cause.
Skip the ruff, bump a float’s thread,
Build unchecked — I twitch my head.
Carrot cheers for tidy laws. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly identifies the addition of a dependabot ignore rule for ruff updates, which is a key part of the changeset and is neither misleading nor generic. It directly reflects a real aspect of the PR, meeting the criteria for a concise and focused title.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}