Native triggers for workflow dependency by ShaharNaveh · Pull Request #6253 · RustPython/RustPython

Walkthrough

The CI workflow now includes explicit push (main, release branches) and pull_request event triggers alongside existing merge_group and workflow_dispatch triggers. The PR auto-commit workflow transitions from direct pull_request_target triggers to a workflow_run trigger that activates after CI completion, with a conditional guard ensuring execution only for pull requests with successful CI runs.

Changes

Sequence Diagram

sequenceDiagram
    participant Developer
    participant PR as Pull Request
    participant CI as CI Workflow
    participant AutoCommit as PR Auto-Commit<br/>Workflow
    participant Repo as Repository

    Developer->>PR: Push commit or open PR
    PR->>CI: Trigger on push/pull_request events
    activate CI
    CI->>CI: Run tests, checks
    CI-->>Repo: Report completion status
    deactivate CI
    
    Note over AutoCommit: Listens for CI<br/>workflow_run completion
    CI-->>AutoCommit: Trigger workflow_run (on success)
    activate AutoCommit
    AutoCommit->>AutoCommit: Guard: Check if event<br/>is pull_request<br/>and CI succeeded
    AutoCommit->>AutoCommit: Run cargo fmt
    AutoCommit->>Repo: Commit & push formatted changes
    deactivate AutoCommit

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Review the new trigger configuration in ci.yaml to ensure correct branch patterns for push events
• Verify the workflow_run trigger condition and job guard logic in pr-auto-commit.yaml properly filter for pull_request events and successful CI runs
• Confirm the removal of wait-for-status-checks step doesn't introduce timing issues

Possibly related PRs

• Update CI auto-formate #6237: Also modifies .github/workflows/pr-auto-commit.yaml and its triggering/guard logic for rustfmt auto-commit functionality
• Update CI auto-format #6233: Also switches CI and auto-format workflows to use workflow_run triggers for post-CI execution

Suggested reviewers

• youknowone

Poem

🐰 A workflow dance, now orchestrated clean,
CI runs first, the scene's serene,
Then auto-commit hops in with flair,
Formatting changes floating through the air! ✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}