Move `wtf8` -> `crates/wtf8` by ShaharNaveh · Pull Request #6257 · RustPython/RustPython

ShaharNaveh

Walkthrough

The workspace configuration is updated to reorganize the wtf8 crate into a subdirectory structure. The "wtf8" member is removed from the workspace members list, and the rustpython-wtf8 dependency path is updated from "wtf8" to "crates/wtf8" while maintaining the existing version constraint.

Changes

Cohort / File(s)	Change Summary
Workspace Configuration `Cargo.toml`	Removed "wtf8" from [workspace] members; updated rustpython-wtf8 dependency path from "wtf8" to "crates/wtf8"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Verify the wtf8 crate physically exists at crates/wtf8 location
Confirm no other Cargo.toml files or workspace references need updating

Poem

🐰 Hops along with glee

Into crates/ we organize,
Workspace tidy, nested and wise,
wtf8 finds its rightful place,
Dependencies dance with newfound grace!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main change: moving the wtf8 crate from the root directory to the crates subdirectory, which aligns with the Cargo.toml modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 609d99f and 94c9084.

📒 Files selected for processing (1)

Cargo.toml (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-09-28T22:22:55.921Z

Learnt from: reactive-firewall
Repo: RustPython/RustPython PR: 6176
File: .github/workflows/Check_Tests.yml:133-141
Timestamp: 2025-09-28T22:22:55.921Z
Learning: In the RustPython project's CI-5974-Test-RustPython-Integration action, the override-rustpython-path input is marked as required but has runtime fallback logic that defaults to RUSTPYTHONPATH environment variable or "Lib" if neither is provided, making explicit specification unnecessary in most cases.

Applied to files:

Cargo.toml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

GitHub Check: Run snippets and cpython tests on wasm-wasi
GitHub Check: Check the WASM package and demo
GitHub Check: Run tests under miri
GitHub Check: Run snippets and cpython tests (windows-latest)
GitHub Check: Run snippets and cpython tests (ubuntu-latest)
GitHub Check: Run snippets and cpython tests (macos-latest)
GitHub Check: Run rust tests (ubuntu-latest)
GitHub Check: Ensure compilation on various targets
GitHub Check: Run rust tests (windows-latest)
GitHub Check: Run rust tests (macos-latest)
GitHub Check: auto_format

🔇 Additional comments (1)

Cargo.toml (1)

162-162: Dependency path correctly updated to reflect new crate location.

Migration verified complete and correct. The rustpython-wtf8 path on line 162 has been properly updated to "crates/wtf8", the workspace members list includes the "crates/*" glob pattern to auto-discover the relocated crate, and no stale references to the old path remain. The crate structure is now consistent with other crates under crates/.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}