Move `compiler/literal` -> `crates/literal` by ShaharNaveh · Pull Request #6259 · RustPython/RustPython

ShaharNaveh

Walkthrough

The literal crate is relocated from the compiler directory to the crates directory. Workspace member declarations and dependency path references in Cargo.toml are updated to reflect this new location.

Changes

Cohort / File(s)	Summary
Crate relocation `Cargo.toml`	Removed `compiler/literal` from workspace members and added `crates/literal`. Updated `rustpython-literal` workspace dependency path from `compiler/literal` to `crates/literal`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Configuration-only change affecting a single manifest file
Straightforward path updates with no logic modifications or new features

Poem

🐰 The literal crate hops along,
From compiler to crates it belongs,
A simple move, clean and bright,
Paths updated, all feels right! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely describes the main change: moving the literal crate from compiler/ to crates/ directory.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 609d99f and d92303b.

📒 Files selected for processing (1)

Cargo.toml (1 hunks)

🔇 Additional comments (2)

Cargo.toml (2)

121-139: Workspace glob pattern correctly includes the relocated crate.

The glob pattern "crates/*" successfully matches crates/literal and will automatically discover it as a workspace member, consistent with how crates/doc is handled. The workspace configuration is correct.

157-157: Migration of compiler/literal → crates/literal verified as complete.

The workspace dependency path at line 157 has been correctly updated to { path = "crates/literal", version = "0.4.0" }. Verification confirms:

✓ crates/literal directory exists with valid Cargo.toml

✓ Workspace glob pattern "crates/*" automatically includes the new crate

✓ No stale references to the old compiler/literal path remain

✓ Follows existing project conventions for crates in the crates/ directory

No further action needed.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}