Move `derive` -> `crates/derive` by ShaharNaveh · Pull Request #6264 · RustPython/RustPython
Walkthrough
Workspace configuration updated: the derive crate was removed from the top-level workspace members and the rustpython-derive workspace dependency path changed from "derive" to "crates/derive", version unchanged.
Changes
| Cohort / File(s) | Change Summary |
|---|---|
Workspace manifestCargo.toml |
Removed derive from [workspace] members; changed rustpython-derive dependency path from path = "derive" to path = "crates/derive" (version remains 0.4.0). |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
- Small, localized manifest edits; verify workspace member removal and dependency path update.
- Check CI/workspace build and any references to the old
derivepath in scripts or docs.
Possibly related PRs
- Move
vm/sre_engine->crates/sre_engine#6265 — similar workspace member path move tocrates/forsre_engine. - Move
jit->crates/jit#6262 — similar crate relocation and workspace dependency path update forjit.
Suggested reviewers
- youknowone
Poem
🐰 Hop, hop — a crate on the move,
From root to crates it finds its groove,
Paths adjusted, tidy and neat,
Build tree humming with tiny feet. 🥕
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The pull request title directly and accurately describes the main change: moving the 'derive' crate from the root directory to 'crates/derive'. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✨ Finishing touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
📜 Recent review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Cargo.toml(1 hunks)
🔇 Additional comments (1)
Cargo.toml (1)
143-143: Derive crate relocation is complete and correctly configured.All verification checks passed:
- ✓ Crate successfully moved to
crates/derive/with valid metadata- ✓ Stale
derive/directory removed- ✓ No remaining references to old
path = "derive"in manifests- ✓
Cargo.locksynchronized and consistent- ✓ Workspace dependency path correctly updated on line 143
- ✓ Glob pattern
crates/*properly captures relocated crateThe change integrates correctly with the broader workspace reorganization.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.