Move `stdlib` -> `crates/stdlib` by ShaharNaveh · Pull Request #6268 · RustPython/RustPython
Walkthrough
The workspace Cargo.toml was updated: the top-level workspace member stdlib was removed and the rustpython-stdlib workspace dependency path was changed from stdlib to crates/stdlib.
Changes
| Cohort / File(s) | Change Summary |
|---|---|
Workspace configuration Cargo.toml |
Removed stdlib from [workspace] members; updated [workspace.dependencies] entry for rustpython-stdlib to use path crates/stdlib instead of stdlib. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Points to check:
- Ensure no CI scripts, build tooling, or other Cargo.toml files reference the removed top-level
stdlibpath. - Confirm other workspace dependency paths still resolve to the intended
crates/locations.
Possibly related PRs
- Move
compiler/codegen->crates/codegen#6260: Performs the same pattern — removes a workspace member and changes a workspace dependency path tocrates/.... - Move
common->crates/common#6256: Similar workspace restructuring, migrating a top-level member tocrates/<name>and updating dependency paths.
Poem
🐰 I nudged the Cargo map tonight,
Moved
stdlibto a cozier site.
Crates in rows, a tidy scene,
Builds hum soft and errors lean.
Hooray — a hop, a patch, a bite! 🥕
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title 'Move stdlib -> crates/stdlib' directly and clearly describes the main change: relocating the stdlib directory to a new path under crates/, which aligns with the file modifications shown in the raw summary. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✨ Finishing touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
📜 Recent review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
Cargo.toml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Run snippets and cpython tests (windows-latest)
- GitHub Check: Run snippets and cpython tests (macos-latest)
- GitHub Check: Run rust tests (macos-latest)
- GitHub Check: Check Rust code with clippy
- GitHub Check: Ensure compilation on various targets
- GitHub Check: auto_format
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.