Move `vm` -> `crates/vm` by ShaharNaveh · Pull Request #6269 · RustPython/RustPython

ShaharNaveh

Warning

Rate limit exceeded

@ShaharNaveh has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 41 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 6e4e9b8 and 256fd81.

📒 Files selected for processing (11)

Cargo.toml (1 hunks)
crates/vm/Lib/core_modules/codecs.py (1 hunks)
crates/vm/Lib/core_modules/copyreg.py (1 hunks)
crates/vm/Lib/core_modules/encodings_utf_8.py (1 hunks)
crates/vm/Lib/python_builtins/__hello__.py (1 hunks)
crates/vm/Lib/python_builtins/__phello__ (1 hunks)
crates/vm/Lib/python_builtins/_frozen_importlib.py (1 hunks)
crates/vm/Lib/python_builtins/_frozen_importlib_external.py (1 hunks)
crates/vm/Lib/python_builtins/_thread.py (1 hunks)
crates/vm/build.rs (1 hunks)
wasm/wasm-unknown-test/Cargo.toml (1 hunks)

Walkthrough

The pull request reorganizes the workspace by moving the vm crate into a crates/ subdirectory. All workspace member declarations, dependency paths, and internal module references are updated to reflect the new location.

Changes

Cohort / File(s)	Summary
Workspace restructuring `Cargo.toml`, `example_projects/barebone/Cargo.toml`, `example_projects/frozen_stdlib/Cargo.toml`	Removed "vm" from workspace members and updated rustpython-vm dependency paths from `vm` or `../../vm` to `crates/vm` or `../../crates/vm` respectively.
Internal path adjustment `crates/vm/src/vm/mod.rs`	Updated py_freeze! module path from `../extra_tests/snippets` to `../../extra_tests/snippets` to accommodate the new crate location.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

All changes follow the same pattern (path updates), minimizing cognitive load
Verify that all path references are updated consistently across workspace members
Confirm the internal module path adjustment in mod.rs correctly reflects the new directory nesting level

Possibly related PRs

Move pylib -> crates/pylib #6225: Performs the same workspace reorganization pattern, moving rustpython-pylib into crates/ and updating corresponding Cargo.toml paths.

Suggested reviewers

youknowone
coolreader18

Poem

🐰 The vm hops into its cozy crates/ burrow,
All paths now point the way just so,
Dependencies reorganized, clean and narrow,
This little rabbit made the workspace glow! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Move `vm` -> `crates/vm`' directly and accurately describes the main change: relocating the vm directory to crates/vm, which is confirmed by all file modifications showing path updates from 'vm' to 'crates/vm'.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}