Move `PrintExpr` to `IntristicFunction1` by ShaharNaveh · Pull Request #6324 · RustPython/RustPython

youknowone

Walkthrough

Replaces the specialized PrintExpr instruction with an intrinsic-based flow: the compiler emits CallIntrinsic1(IntrinsicFunction1::Print) followed by Pop, the bytecode removes PrintExpr and adds IntrinsicFunction1::Print, and the VM dispatches printing via the intrinsic invoking sys.displayhook.

Changes

Cohort / File(s)	Summary
Code Generation `crates/codegen/src/compile.rs`	Replaced direct `PrintExpr` emission with `CallIntrinsic1(IntrinsicFunction1::Print)` then `Pop` in both top-level expression-statement paths.
Bytecode Definitions `crates/compiler-core/src/bytecode.rs`	Added `IntrinsicFunction1::Print`. Removed `Instruction::PrintExpr`, its stack-effect handling, and disassembly formatting path.
VM Execution `crates/vm/src/frame.rs`	Removed `PrintExpr` handler and `print_expr()` method. Added intrinsic dispatcher case for `IntrinsicFunction1::Print` that calls `sys.displayhook` with the argument.

Sequence Diagram(s)

sequenceDiagram
  participant Codegen
  participant Bytecode
  participant VM
  participant Sys as sys.displayhook

  Note over Codegen,Bytecode: Compilation
  Codegen->>Bytecode: emit CallIntrinsic1(Print)
  Codegen->>Bytecode: emit Pop

  Note over Bytecode,VM: Execution
  VM->>VM: execute CallIntrinsic1(Print)
  VM->>Sys: invoke displayhook(arg)
  Sys-->>VM: return
  VM->>VM: execute Pop (cleanup)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Attention areas:
- Both codegen locations emit the exact intrinsic + pop sequence.
- VM intrinsic dispatcher correctly mirrors previous PrintExpr semantics (argument handling, exceptions).
- Bytecode enum and stack-effect updates are consistent across consumers (disassembler, tests).

Possibly related PRs

Remove ImportNameless bytecode #6325 — Similar removal of a dedicated instruction variant and replacement with intrinsic-based handling across codegen/bytecode/frame.
typing TypeAlias #5945 — Same low-level refactor pattern: drop an Instruction variant and route through CallIntrinsic.
Instruction::Resume #5944 — Converts specialized instructions into CallIntrinsic1 intrinsics and updates compiler + VM handling.

Suggested reviewers

youknowone

Poem

🐰 I nibble bytes and hop between lanes,
I swapped the old print for intrinsic chains.
CallIntrinsic hums, then Pop wipes the track,
sys.displayhook answers — no rabbit needs slack! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the main change: moving PrintExpr from a dedicated bytecode instruction to an IntrinsicFunction1 variant, which aligns with all modifications across compile.rs, bytecode.rs, and frame.rs.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 70c3bf4 and fcf6dec.

📒 Files selected for processing (3)

crates/codegen/src/compile.rs (2 hunks)
crates/compiler-core/src/bytecode.rs (1 hunks)
crates/vm/src/frame.rs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

crates/compiler-core/src/bytecode.rs
crates/codegen/src/compile.rs
crates/vm/src/frame.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

GitHub Check: Run snippets and cpython tests (windows-latest)
GitHub Check: Run snippets and cpython tests on wasm-wasi
GitHub Check: Run tests under miri
GitHub Check: Check the WASM package and demo
GitHub Check: Run snippets and cpython tests (macos-latest)
GitHub Check: Run snippets and cpython tests (ubuntu-latest)
GitHub Check: Run rust tests (macos-latest)
GitHub Check: Check Rust code with clippy
GitHub Check: Ensure compilation on various targets
GitHub Check: Run rust tests (windows-latest)
GitHub Check: Run rust tests (ubuntu-latest)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}