nt.terminalsize by youknowone · Pull Request #6374 · RustPython/RustPython

Walkthrough

Default to stdout (fd=1), derive a Windows HANDLE via crt_fd::Borrowed/as_handle(), call GetConsoleScreenBufferInfo; on ERROR_ACCESS_DENIED open CONOUT$, retry GetConsoleScreenBufferInfo, close temp handle, compute columns/lines from csbi.srWindow, propagate other errors via errno_err(vm).

Changes

Sequence Diagram

sequenceDiagram
    participant VM as VM code
    participant crt_fd as crt_fd resolver
    participant WinAPI as Windows API
    participant CONOUT as CONOUT$ file

    VM->>crt_fd: Borrow fd (fd.unwrap_or(1))
    crt_fd-->>VM: as_handle() -> HANDLE
    VM->>WinAPI: GetConsoleScreenBufferInfo(HANDLE)
    alt Success
        WinAPI-->>VM: CONSOLE_SCREEN_BUFFER_INFO
        VM-->>VM: compute columns/lines from srWindow
    else ERROR_ACCESS_DENIED
        WinAPI-->>VM: ERROR_ACCESS_DENIED
        VM->>CONOUT: CreateFileW("CONOUT$", GENERIC_READ|GENERIC_WRITE)
        CONOUT-->>VM: temp HANDLE
        VM->>WinAPI: GetConsoleScreenBufferInfo(temp HANDLE)
        WinAPI-->>VM: CONSOLE_SCREEN_BUFFER_INFO
        VM->>CONOUT: CloseHandle(temp HANDLE)
        VM-->>VM: compute columns/lines from srWindow
    else OtherError
        WinAPI-->>VM: error
        VM-->>VM: errno_err(vm) (propagate)
    end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–30 minutes

• Verify correct crt_fd::Borrowed / as_handle() usage and fd defaulting.
• Check handling of INVALID_HANDLE_VALUE and mapping to errno_err(vm).
• Confirm CreateFileW flags for CONOUT$, retry logic, and CloseHandle to avoid leaks.
• Validate columns/lines computation from csbi.srWindow and error propagation paths.

Possibly related PRs

• Rework crt_fd to be more aligned with io-safety #5789 — crt_fd refactor introducing crt_fd::Borrowed / as_handle() which this change depends on.

Poem

🐰 I hopped from fd to handle bright,

I peeked the console in the night.
If access barred, I sought CONOUT$,
retried, counted rows and columns stout.
Closed the gate and twitched my nose.

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}