◐ Shell
clean mode source ↗

Update `test/libregrtest` to CPython 3.13.10 by fanninpm · Pull Request #6410 · RustPython/RustPython

108-124: Verify Windows polluters list is intentionally empty.

The ENV_POLLUTING_TESTS_WINDOWS list is empty while Linux and macOS have several entries. Based on the PR description mentioning ongoing Windows bisecting work, is this intentional or does it indicate work in progress?


297-320: LGTM: Clean separation between normal runs and polluter verification.

The RUSTPYTHON_SKIP_ENV_POLLUTERS flag correctly skips known polluters during regular test runs while the dedicated verification steps (added later) specifically test those polluters. This is a sound architectural choice.


136-136: LGTM: Formatting improvements enhance consistency.

The formatting changes throughout the file improve readability and maintain consistency in the workflow structure without affecting functionality.

Also applies to: 167-167, 179-182, 432-432, 469-469, 484-485, 492-494


323-349: The exit code 3 assumption in the workflow is correct.

Exit code 3 is indeed the correct signal from CPython's test framework when --fail-env-changed detects environment pollution. This is confirmed in CPython's /usr/lib/python3.11/test/libregrtest/main.py where the code explicitly returns sys.exit(3) when both the --fail-env-changed flag is set and environment changes are detected. The workflow logic correctly relies on this exit code to determine if a test is still polluting the environment.