fix concurrent socket close by youknowone · Pull Request #6612 · RustPython/RustPython

youknowone

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The PySocket::close method in socket.rs was refactored to replace detach-based ownership checking with direct socket ownership transfer from the write lock. The new approach closes the socket only when one exists, eliminating explicit INVALID_SOCKET comparisons and simplifying the closing logic.

Changes

Cohort / File(s)	Change Summary
Socket close logic refactoring `crates/stdlib/src/socket.rs`	Replaced detach-based ownership check in `PySocket::close` with direct ownership transfer; now calls `close_inner(into_sock_fileno(sock))` only when a socket is present, removing explicit `INVALID_SOCKET` check

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Fix windows socket #6408: Modifies the same socket.rs file and PySocket::close method, adjusting how socket ownership and closing are handled.

Poem

🐰 A socket once closed with a dance,
Now straightforward—no detach romance!
Direct ownership, clear and bright,
No INVALID_SOCKET in sight!
Simplicity hops with delight! 🎉

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b3b97ca and 6be2e95.

📒 Files selected for processing (1)

crates/stdlib/src/socket.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}