◐ Shell
clean mode source ↗

auto mark parent tests by youknowone · Pull Request #6778 · RustPython/RustPython

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This pull request modifies CI/CD automation and test infrastructure across three files: removing a label-based conditional guard from the auto-format workflow, enhancing test failure detection with AST-based inheritance analysis, and optimizing cache initialization in patch line processing.

Changes

Cohort / File(s) Summary
CI/CD Workflow
.github/workflows/pr-auto-commit.yaml
Removed conditional guard preventing auto_format job execution when PR has skip:ci label; job now runs unconditionally
Test Automation
scripts/auto_mark_test.py
Enhanced test pattern detection from "Run tests? sequentially" to "Run <n> tests? sequentially"; added build_inheritance_info() and find_method_definition() helpers for AST-based inheritance analysis; modified remove_expected_failures() to resolve method definitions across class inheritance hierarchies
Patch Processing
scripts/lib_updater.py
Refactored cache initialization in iter_patch_lines() to pre-populate class end lines before Phase 1 processing, removing incremental cache updates during iteration

Possibly related PRs

  • RustPython/RustPython#6706: Modifies the same .github/workflows/pr-auto-commit.yaml workflow for formatting/commit step execution control

Poem

🐰 The workflows now run without delay,
While tests trace inheritance their way,
With caches built before the race,
Each change finds its rightful place! ✨

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.