Bump mimetypes to 3.14.2 by moreal · Pull Request #6808 · RustPython/RustPython
This pull request is extracted from #6784
Important
Review skipped
Review was skipped due to path filters
⛔ Files ignored due to path filters (6)
Lib/mimetypes.pyis excluded by!Lib/**Lib/test/test_httplib.pyis excluded by!Lib/**Lib/test/test_httpservers.pyis excluded by!Lib/**Lib/test/test_mimetypes.pyis excluded by!Lib/**Lib/test/test_ssl.pyis excluded by!Lib/**Lib/test/test_urllib2.pyis excluded by!Lib/**
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
The job run on window-2025 has failed with the following lines. It seems not related about updating mimetypes module to 3.14.2 🤔
======================================================================
FAIL: test_socketserver (test.test_ssl.ThreadedTests.test_socketserver)
Using socketserver to create and manage SSL connections.
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\a\RustPython\RustPython\Lib\test\test_ssl.py", line 3552, in test_socketserver
self.assertEqual(d1, d2)
^^
AssertionError: b'# Test the support for SSL and sockets\r\[254224 chars]\r\n' != b''
----------------------------------------------------------------------
moreal
marked this pull request as ready for review
| else: | ||
| s.close() | ||
|
|
||
| @unittest.expectedFailure # TODO: RUSTPYTHON |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this line
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I don't have Windows machine, I cannot check the test but it seems to fail in only Windows environment. I'll mark it as unittest.expectedFailureIfWindows.
In my local macOS environment, the following command doesn't fail.
cargo run --release -- -m unittest test.test_ssl.ThreadedTests.test_socketserver
📦 Library Dependencies
The following Lib/ modules were modified. Here are their dependencies:
Click to expand dependency information
[+] lib: cpython/Lib/mimetypes.py
[+] test: cpython/Lib/test/test_mimetypes.py
soft_deps:
- [x] mimetypes
Legend:
[+]path exists in CPython[x]up-to-date,[ ]outdatednative:Rust/C extension modules
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍