fix clippy 1.93.0 by youknowone · Pull Request #6836 · RustPython/RustPython

youknowone

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Updates function pointer casting patterns across multiple modules to use explicit intermediate pointer casts (*const ()) before final type conversion. Changes affect signal handler registration, hash sentinel detection, memory function address computation, and method descriptor comparison.

Changes

Cohort / File(s)	Summary
Signal Handler Casting `crates/stdlib/src/faulthandler.rs`, `crates/vm/src/stdlib/signal.rs`	Function pointers cast to `libc::sighandler_t` now use intermediate `*const ()` cast instead of direct type conversion for faulthandler fatal/user signal handlers and signal module handler installation
Pointer Address Computation `crates/vm/src/stdlib/ctypes.rs`	Function addresses for `_memmove_addr` and `_memset_addr` computed via `*const ()` intermediate cast before usize conversion instead of direct cast
Type-Unsafe Pointer Comparisons `crates/vm/src/class.rs`, `crates/vm/src/vm/method.rs`	Hash sentinel detection and method descriptor comparison now use intermediate `*const ()` pointer cast for safe type-level comparisons

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Faulthandler #6406: Modifies signal-handling code in faulthandler.rs; this PR adjusts function-pointer cast patterns for the same handler-wiring code paths.
Faulthandler #6400: Overlaps with faulthandler.rs changes; both PRs modify signal-handler installation and casting logic.
__hash__ to slot_wrapper #6480: Related through class.rs __hash__ slot handling; this PR refines the pointer cast used for hash_not_implemented sentinel detection.

Suggested reviewers

ShaharNaveh
arihant2math

Poem

🐰 Through pointers cast with careful care,
Each function finds its destined lair,
No direct leaps, just steps between,
The safest path our code has seen! ✨

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}