Update os constant to libc `0.2.180` & target cpython 3.14 by ShaharNaveh · Pull Request #6917 · RustPython/RustPython
📝 Walkthrough
Walkthrough
Added Android-specific POSIX scheduling constants (SCHED_DEADLINE and SCHED_NORMAL) to RustPython's posix module via libc imports. Updated libc version dependency from 0.2.177 to 0.2.180 and adjusted Python documentation references from version 3.13 to 3.14.
Changes
| Cohort / File(s) | Summary |
|---|---|
Android POSIX Scheduling Constants crates/vm/src/stdlib/posix.rs |
Added Android-targeted #[pyattr] exports for SCHED_DEADLINE and SCHED_NORMAL from libc, making these scheduling constants available as Python attributes on Android targets. |
Libc Dependency and Documentation scripts/libc_posix.py |
Updated libc version constant from 0.2.177 to 0.2.180 and updated Python os module documentation URL reference from version 3.13 to 3.14. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
- Update
os.pyfrom 3.13.5 #6076: Adds other SCHED_\* constants as #[pyattr] in posix.rs, part of a series of scheduling constant exports. - Attempt to automate posix consts #6117: Previously updated scripts/libc_posix.py with LIBC_VERSION changes and coordinated posix.rs constant exports.
- Update
libcto 0.2.177 #6300: Modifies libc-related imports and constants in the same posix.rs file with libc version updates.
Suggested reviewers
- youknowone
Poem
🐰 Android hops with scheduling cheer,
DEADLINE and NORMAL, crisp and clear,
Constants exposed for all to see,
While libc dances version 0.2.180 spree! ⚡
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately reflects the main changes: updating libc to version 0.2.180 and targeting CPython 3.14, which are the primary modifications evident in both modified files. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
- 📝 Generate docstrings
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.