more deps grouping by youknowone · Pull Request #6931 · RustPython/RustPython
Caution
Review failed
The pull request is closed.
📝 Walkthrough
Walkthrough
The PR expands the DEPENDENCIES mapping in scripts/update_lib/deps.py by adding numerous test entries to existing modules (int, pickle, weakref, codecs, ast, xml, multiprocessing, collections, dbm) and introducing new module groupings (compile, math, float, zipfile, smtplib, profile, string, os, pyrepl, concurrent, sysconfig, tkinter) with associated test files and hard dependencies.
Changes
| Cohort / File(s) | Summary |
|---|---|
Dependency Mapping Expansion scripts/update_lib/deps.py |
Expanded DEPENDENCIES dictionary with new test entries for existing modules (int, pickle, weakref, codecs, ast, xml, multiprocessing, collections, dbm) and introduced new module groupings (compile, math, float, zipfile, smtplib, profile, string, os, pyrepl, concurrent, sysconfig, tkinter) each with corresponding test files and hard dependencies. Reorganized concurrent tests and added system-level module support. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
- [update_lib] deps grouping #6864: Both PRs modify
scripts/update_lib/deps.pyby expanding and restructuring the DEPENDENCIES mapping with new test groupings. - improve deps CI formatting and name resolution #6847: The expanded DEPENDENCIES mapping in this PR directly affects dependency resolution functions like
resolve_hard_dep_parentthat were introduced in that PR. - [update_lib] show dependent tests in
depssubcommand #6828: Both PRs modifyscripts/update_lib/deps.pyand the reshaped DEPENDENCIES mapping interacts with test-discovery routines introduced in that PR.
Suggested reviewers
- moreal
- ShaharNaveh
Poem
🐰 With whiskers twitching, I compile with glee,
Test entries grouped from sea to sea!
New modules mapped with care so fine,
Dependency trees in perfect line. ✨
✨ Finishing touches
- 📝 Generate docstrings
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.