Fix test_asyncio for windows by youknowone · Pull Request #6959 · RustPython/RustPython

youknowone

📝 Walkthrough

Walkthrough

This pull request makes two distinct changes: removing test_asyncio from the Windows test skip list in CI configuration, and augmenting exception handler cleanup block generation in the codegen compiler to carry exception name data for named exception handlers.

Changes

Cohort / File(s)	Summary
CI Configuration `.github/workflows/ci.yaml`	Removed `test_asyncio` from Windows-specific test skip list (WINDOWS_SKIPS), expanding the set of tests run on Windows platform.
Exception Handler Cleanup `crates/codegen/src/compile.rs`	Replaced two `push_fblock` calls with `push_fblock_full` for HandlerCleanup fblocks, adding FBlockDatum parameter to carry exception name context. Passes `FBlockDatum::ExceptionName(name)` for named handlers and `FBlockDatum::None` for unnamed handlers.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly Related PRs

Fix asyncio compile #6739: Modifies exception-unwind handling in compile.rs with changes to fblock/unwind routing logic.
Add _asyncio and add test_asyncio #6838: Directly related CI change involving the same WINDOWS_SKIPS entry for test_asyncio.
Rework exception compiler #6909: Modifies exception handling by switching to push_fblock_full and passing FBlockDatum for cleanup fblocks.

Poem

🐰 A rabbit hops through cleanup blocks,
Exception names in data locks,
Windows tests now run with glee,
No more skips on asyncio spree!
Handlers whisper secrets clear, ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix test_asyncio for windows' aligns with the main change shown in the raw summary: removing test_asyncio from WINDOWS_SKIPS in .github/workflows/ci.yaml to fix its execution on Windows.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}