Update CI ruff to `0.15.4` by ShaharNaveh · Pull Request #7250 · RustPython/RustPython
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
extra_tests/snippets/builtin_filter.pyextra_tests/snippets/stdlib_io.py
✅ Files skipped from review due to trivial changes (1)
- extra_tests/snippets/builtin_filter.py
🚧 Files skipped from review as they are similar to previous changes (1)
- extra_tests/snippets/stdlib_io.py
📝 Walkthrough
Walkthrough
Bumps ruff-action from 0.14.11 to 0.15.4 in two GitHub workflows, adds a MinimalRaw test for RawIOBase.isatty() on closed files, and normalizes minor formatting in a builtin filter test snippet.
Changes
| Cohort / File(s) | Summary |
|---|---|
CI workflows /.github/workflows/ci.yaml, /.github/workflows/pr-auto-commit.yaml |
Updated ruff-action version from 0.14.11 to 0.15.4. No other workflow behavior changes. |
New test snippet extra_tests/snippets/stdlib_io.py |
Added MinimalRaw(RawIOBase) and test asserting isatty() is False when open and raises ValueError after close. |
Test formatting tweak extra_tests/snippets/builtin_filter.py |
Minor formatting normalization: removed redundant parentheses in lambda conditions; no behavior change. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
- Update ruff to 0.14.11 in the CI #6708: Earlier bump of
ruff-actionversion in the same workflow files. - Ruff as part of PR auto-format #6421: Modifies how
ruff-actionis invoked/arguments in GitHub workflows. - Update ruff CI version #6418: Changes to Ruff installation/usage in CI workflows.
Suggested reviewers
- youknowone
Poem
🐰 I nibble bytes and hop through test and CI,
Bumped ruff, wrote MinimalRaw, then gave a sigh.
isatty checked, closed file found—no fright,
A little rabbit cheers the green build light. 🥕
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately describes the main change: bumping ruff-action from 0.14.11 to 0.15.4 in CI workflows. However, the changeset includes unrelated modifications to test files (stdlib_io.py and builtin_filter.py) that are not referenced in the title. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.