Prevent shell injection by moreal · Pull Request #7310 · RustPython/RustPython

moreal

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b1cddc4 and de1ba40.

📒 Files selected for processing (3)

.github/workflows/pr-auto-commit.yaml
.github/workflows/release.yml
.github/workflows/update-doc-db.yml

📝 Walkthrough

Walkthrough

This PR refactors three GitHub Actions workflows to use intermediate environment variables instead of directly interpolating GitHub context expressions. Changes replace direct references to github.event and inputs with environment variables (HEAD_REF, PRE_RELEASE_INPUT, PYTHON_VERSION) across multiple steps.

Changes

Cohort / File(s)	Summary
GitHub Actions Workflow Refactoring `.github/workflows/pr-auto-commit.yaml`, `.github/workflows/release.yml`, `.github/workflows/update-doc-db.yml`	Introduces intermediate environment variables to replace direct GitHub context interpolations. Adds HEAD_REF for git push references, PRE_RELEASE_INPUT for release type determination, and PYTHON_VERSION for version references in step logic and commit messages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop through the workflows, so neat and so grand,
Environment variables now take their stand,
No more direct refs, just clean-cut and clear,
The release will flow with a cheer and a jeer! 🎉

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Prevent shell injection' directly and clearly describes the main security objective of the changeset: addressing shell injection vulnerabilities in GitHub workflows by replacing direct command interpolation with environment variables.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}