replace auto commit to format suggestion by youknowone · Pull Request #7375 · RustPython/RustPython

youknowone

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 9fe86054-7616-4cfa-bedf-8228f5c01b8f

📥 Commits

Reviewing files that changed from the base of the PR and between fc1c278 and 8e48008.

📒 Files selected for processing (2)

.github/workflows/pr-auto-commit.yaml
.github/workflows/pr-format.yaml

📝 Walkthrough

Walkthrough

Removed the vulnerable pr-auto-commit.yaml workflow that auto-committed formatting changes to PRs, replacing it with a new pr-format.yaml workflow that performs format checks and posts non-invasive formatting suggestions via reviewdog instead.

Changes

Cohort / File(s)	Summary
GitHub Actions Workflows `.github/workflows/pr-auto-commit.yaml`, `.github/workflows/pr-format.yaml`	Deleted vulnerable auto-commit workflow that directly interpolated branch names into shell commands. Added read-only format-check workflow using reviewdog to post inline formatting suggestions without committing to the PR branch.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Prevent shell injection #7310 — Modifies the same pr-auto-commit.yaml workflow to address HEAD ref handling concerns.
Ruff as part of PR auto-format #6421 — Updates GitHub Actions formatting workflows with Ruff integration changes.
Update CI auto-formate #6237 — Removes the pr-auto-commit auto-commit workflow and replaces it with a format-check workflow approach.

Suggested reviewers

ShaharNaveh

Poem

🐰 A workflow once pushed with secrets so near,
Now safely suggests—without commit or fear!
Reviewdog whispers formatting advice,
No shell injections, no malicious splice,
The rabbit hops on, the pipeline is bright! ✨

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}