◐ Shell
clean mode source ↗

Unified action for installing Linux deps by ShaharNaveh · Pull Request #7381 · RustPython/RustPython

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 221eabc0-0af7-4a9f-b3c6-8ac106138e87

📥 Commits

Reviewing files that changed from the base of the PR and between 7bb83b0 and 11f1af7.

📒 Files selected for processing (1)
  • .github/actions/install-linux-deps/action.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/actions/install-linux-deps/action.yml

📝 Walkthrough

Walkthrough

Adds a new composite GitHub Action at .github/actions/install-linux-deps/action.yml to conditionally install Linux packages via boolean inputs, and refactors .github/workflows/ci.yaml to replace inline apt-get installs with calls to that action in relevant CI jobs.

Changes

Cohort / File(s) Summary
New composite action
.github/actions/install-linux-deps/action.yml
Adds a composite GitHub Action exposing boolean inputs (gcc-multilib, musl-tools, gcc-aarch64-linux-gnu, clang) and a shell step that conditionally constructs an apt-get package list and runs sudo apt-get update + sudo apt-get install --no-install-recommends when inputs are true.
CI workflow updates
.github/workflows/ci.yaml
Replaces inline sudo apt-get update/install steps with uses: ./.github/actions/install-linux-deps invocations in multiple jobs (x86 32bit, aarch64, wasm-wasi), passing feature flags; minor whitespace adjustment near Wasmer setup.

Sequence Diagram(s)

sequenceDiagram
  participant Workflow as "CI Workflow Job"
  participant Action as "install-linux-deps Action"
  participant Runner as "Runner / Shell"
  participant Apt as "apt-get (system)"

  Workflow->>Action: uses ./.github/actions/install-linux-deps with flags
  Action->>Runner: execute composite shell step
  Runner->>Apt: sudo apt-get update
  Runner->>Apt: sudo apt-get install --no-install-recommends <conditional pkgs>
  Apt-->>Runner: packages installed
  Runner-->>Action: step completes
  Action-->>Workflow: action finished
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • youknowone

Poem

🐰 I tumbled through CI with a twitchy nose,

One tiny action where the package list grows.
Flags like little carrots, picked when they're due,
Now installs are tidy — compact and true. 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Unified action for installing Linux deps' directly and clearly summarizes the main change: creating a centralized GitHub Action to consolidate Linux dependency installation across multiple CI jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.