fix cron-ci by youknowone · Pull Request #7483 · RustPython/RustPython

ShaharNaveh

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 6401fa58-a631-4345-902e-360a0a2db154

📥 Commits

Reviewing files that changed from the base of the PR and between 4107217 and 36d9705.

📒 Files selected for processing (2)

.github/workflows/cron-ci.yaml
extra_tests/custom_text_test_runner.py

📝 Walkthrough

Walkthrough

CI workflow updates Rust feature flags (stdio, host_env) and improves shell command safety with null-delimiter handling. Test runner refactors method dict access into a helper function and makes module field extraction more robust with fallback logic.

Changes

Cohort / File(s)	Summary
CI Workflow Configuration `.github/workflows/cron-ci.yaml`	Updated `CARGO_ARGS` to include `stdio` and `host_env` features; modified `cargo llvm-cov` command to match; changed Codecov action input parameter from `file:` to `files:`; reworked shell commands in `benchmark` job to use `find -print0` with `xargs -0` for safer filename handling.
Test Runner Refactoring `extra_tests/custom_text_test_runner.py`	Added `_get_method_dict(test)` helper to centralize retrieval of test method's underlying function `__dict__`, reducing repeated attribute access; made suite `"module"` field extraction more robust with conditional regex matching that falls back to `str(test)` if regex fails.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Fix some parts of cron-ci workflow #6724: Overlapping modifications to .github/workflows/cron-ci.yaml for Cargo feature set and codecov-related steps.
Restructure CI with matrix approach and multi-feature support #7376: Related changes to CI feature handling through CARGO_ARGS updates to include additional Rust features.

Suggested reviewers

moreal

Poem

🐰 Hop, skip, and a leap,
Features added, nice and deep,
Safer paths with null delimiters true,
Helper functions make code new,
CI workflows bloom in morning dew!

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}