Resolve shellcheck warning on `ci.yaml` by ShaharNaveh · Pull Request #7501 · RustPython/RustPython

github-advanced-security

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

CI workflow .github/workflows/ci.yaml updated for safer shell handling: quoted outputs and arguments, switched env-polluting-tests iteration to a line-based read loop, quote-wrapped numeric exit comparisons, and quoted $(pwd) for wasmer run --dir.

Changes

Cohort / File(s)	Summary
CI workflow `./.github/workflows/ci.yaml`	Shell-hardening edits: append `cores` to `"$GITHUB_OUTPUT"`; build `TESTS` from `matrix.env_polluting_tests` and iterate with `while IFS= read -r thing; do ... done <<< "$TESTS"`; pass test entries as `-v "${thing}"`; use quoted numeric comparisons (`"${exit_code}"`); quote `$(pwd)` for `wasmer run --dir` in wasm-wasi steps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Cleanup ci.yaml matrix usage #7260 — Related CI workflow edits touching matrix.env_polluting_tests iteration and per-entry handling.

Suggested reviewers

youknowone

Poem

🐇 I hopped through YAML late at night,
Quoted each var to set things right.
Tests now read lines tidy and neat,
Wasmer finds home with quoted feet,
CI hums on—my whiskers bright.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: resolving shellcheck warnings in the ci.yaml workflow file by improving shell quoting and variable handling.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}