Fix clippy pedantic lint by fanninpm · Pull Request #7772 · RustPython/RustPython

ShaharNaveh

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: ba2d5ca3-2beb-4ed2-9cd1-0cde0a151e29

📥 Commits

Reviewing files that changed from the base of the PR and between 83002d7 and 9872c6e.

📒 Files selected for processing (1)

crates/host_env/src/select.rs

📝 Walkthrough

Walkthrough

A #[must_use] attribute is added to the check_err function in the Unix platform module, instructing the compiler to warn if the function's return value is discarded.

Changes

Platform Attribute Enhancement

Layer / File(s)	Summary
Compiler Directive `crates/host_env/src/select.rs`	`#[must_use]` attribute added to `check_err` function to enforce return value handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Poem

🐰 A tiny hop, a compiler's nudge so kind,
"Don't forget the check_err—keep it in mind!"
One small attribute, but oh what it means,
No silent returns upon our Unix machines! 🛡️

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding a #[must_use] attribute to fix a clippy pedantic lint warning in the codebase.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}