◐ Shell
clean mode source ↗

docs: fixed misleading comment about the array method (forEach instead of reduce) used in AverageMean.js by HRIDYANSHU054 · Pull Request #1727 · TheAlgorithms/JavaScript

Conversation

@HRIDYANSHU054

Open in Gitpod know more

Describe your change:

  • Documentation change?
    what was wrong?
    wrong array method in comment

Before:

// This loop sums all values in the 'nums' array using forEach loop
const sum = nums.reduce((sum, cur) => sum + cur, 0)

After:

// This calculates the sum of all values in the 'nums' array using reduce method.  
const sum = nums.reduce((sum, cur) => sum + cur, 0)

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
…d of reduce) used in AverageMean.js

@codecov-commenter

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.76%. Comparing base (ff314a2) to head (d0e1ba9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1727      +/-   ##
==========================================
- Coverage   84.76%   84.76%   -0.01%     
==========================================
  Files         378      378              
  Lines       19742    19738       -4     
  Branches     2955     2957       +2     
==========================================
- Hits        16735    16731       -4     
  Misses       3007     3007              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appgurueu

Just remove the comment. It adds no value.

@HRIDYANSHU054

appgurueu

Co-authored-by: Lars Müller <34514239+appgurueu@users.noreply.github.com>

appgurueu

@HRIDYANSHU054

anandfresh

raklaptudirm