◐ Shell
clean mode source ↗

Resolve duplicate entries for sieve of eratosthenes by SpiderMath · Pull Request #1770 · TheAlgorithms/JavaScript

SpiderMath

Fixes: #1666

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Further description

I kept the SieveOfEratosthenesIntArray implementation, renaming it to SieveOfEratosthenes, removed the boolean implementation, and wrote tests for the same. Apart from that, I've also added comments to conform to the algorithm comment standards.