Minor code readability improvements discovered on code review. by sgpinkus · Pull Request #1003 · actions/setup-python
-
Notifications
You must be signed in to change notification settings - Fork 721
Conversation
Description:
Minor code readability improvements discovered on code review.
- Rename
(Pipenv|Poetry)Cache"patterns" field to "cacheDependencyPath" to be consistent with PipCache, base class, andcache-factory.ts - Rm
CacheDistributor.cacheDependencyPathfield and pass back fromcomputeKeysinstead, simplifyingCacheDistributor.restoreCacheerror check. Rm now not neededconstant.ts.
Related issue:
Check list:
- Mark if documentation changes are required.
- Mark if tests were added or updated to cover the changes.
…eld to "cacheDependencyPath" to be consistent with base class and cache-factory.
…readonly abstract fields of concrete cache implementations. Remove empty CacheDistributor constructor.
…ss back from computeKeys instead, simplifying CacheDistributor.restoreCache error check. Rm now uneeded constant.ts file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 participant
