◐ Shell
clean mode source ↗

Workaround fix for issue with inline namespace thrust by edwinsolisf · Pull Request #3566 · arrayfire/arrayfire

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@edwinsolisf

Temporary fix for inline namespace with thrust compiling with MSVC

Description

  • Is this a new feature or a bug fix?: Temporary fix
  • More detail if necessary to describe all commits in pull request.
  • Why these changes are necessary: workaround for compiler bug affecting template specialization with inline namespace used in ThrustArrayFirePolicy.hpp
  • Potential impact on specific hardware, software or backends: CUDA backend on Windows
  • New functions and their functionality.: None
  • Can this PR be backported to older versions?: NA
  • Future changes not implemented in this PR: None
    Fixes: [Build] MSVC Compiler Bug affecting thrust library in CUDA Backend #3565

Changes to Users

  • No additional options added to the build.
  • No action required by the user

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

@christophe-murphy

Hi Edwin, thanks for finding this! I was trying to compile with Windows and wondering what was going on!

I just have a couple of comments, I think things might have got messed up by clang format. Thanks

@brfire

Would be good to land this, I got stuck on it for a couple hours.

Hi Edwin, there seems to be an issue caused by the clang format apply. I propose these changes.

@christophe-murphy

@edwinsolisf

Looks good to me! Go ahead and merge it

christophe-murphy

Labels