Workaround fix for issue with inline namespace thrust by edwinsolisf · Pull Request #3566 · arrayfire/arrayfire
-
Notifications
You must be signed in to change notification settings - Fork 552
Conversation
Temporary fix for inline namespace with thrust compiling with MSVC
Description
- Is this a new feature or a bug fix?: Temporary fix
- More detail if necessary to describe all commits in pull request.
- Why these changes are necessary: workaround for compiler bug affecting template specialization with inline namespace used in
ThrustArrayFirePolicy.hpp - Potential impact on specific hardware, software or backends: CUDA backend on Windows
- New functions and their functionality.: None
- Can this PR be backported to older versions?: NA
- Future changes not implemented in this PR: None
Fixes: [Build] MSVC Compiler Bug affecting thrust library in CUDA Backend #3565
Changes to Users
- No additional options added to the build.
- No action required by the user
Checklist
- Rebased on latest master
- Code compiles
- Tests pass
- Functions added to unified API
- Functions documented
Hi Edwin, thanks for finding this! I was trying to compile with Windows and wondering what was going on!
I just have a couple of comments, I think things might have got messed up by clang format. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters