◐ Shell
clean mode source ↗

Fix #1079: Use isEmpty() instead of size() == 0 by Pasjonat90D · Pull Request #1119 · biojava/biojava

Pasjonat90D

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

josemduarte

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@Pasjonat90D

Hi,
It looks like the PR is still pending and hasn’t been merged by the CI/CD. Could you please rerun it? Everything seems fine on my side, but the pipeline seems to be stuck.

Thanks!

@josemduarte

I tried re-running but it failed again. It looks like a problem with the SCOP external resource. I'll try again later.

@josemduarte

I've run tests locally and it works fine. I'll merge it.

@Pasjonat90D

Thank you for manually merging the PR. I’ve noticed the additional comments from @jlerbsc. If you would like, please reopen the ticket and assign it to me.

@josemduarte

Good point, just reopened. It was closed automatically by github with this PR.

@jlerbsc

Hi @Pasjonat90D Have you tried using indepth to automatically fix these defects?

@Pasjonat90D

Hi @jlerbsc,
no, I used SonarQube to detect and fix them manually.