◐ Shell
clean mode source ↗

Return an error when aborting due to existing .orig file by fmarier · Pull Request #1 · brave/python-patch

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@fmarier

@fmarier fmarier commented

Jun 29, 2019

Copy link Copy Markdown

Member

See techtonik#60 for a description of the issue and techtonik#61 (comment) for the output of that test after applying this fix.

@fmarier

fmarier commented

Jun 29, 2019

Copy link Copy Markdown

Member Author

The Python 3 test failures can be ignored since they'll be fixed in #2.

@fmarier fmarier self-assigned this

Jun 29, 2019

@fmarier fmarier requested a review from bsclifton

July 3, 2019 00:28

@bsclifton bsclifton left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@fmarier fmarier merged commit d888011 into brave:master

Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@fmarier fmarier

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fmarier @bsclifton