fix: do not clobber dynamic parameters by code-asher · Pull Request #24645 · coder/coder

@code-asher I think this is the main concern, but I think this PR is still an improvement.

Cascading invalidation of options. If field B's allowed options depend on field A, and the user picks B="X", then changes A such that "X" is no longer a valid option, the old hook would replace B with whatever the server returns (first option, empty, etc.). The new hook keeps "X" and you rely on the diagnostic to surface the problem.

This is probably better overall experience so that the user sees their choice preserved but with an explicit error instead of a silent overwrite.

I would add that the scenario mentioned in the bug never surfaced during the original implementation because the websocket reponse was too fast to notice this issue.