feat: modal chat search popup by jaaydenh · Pull Request #25535 · coder/coder
and others added 29 commits
Cherry-picked backend changes from b924883 (Danielle Maywood). Adds chat_status:unread and pr_status:<draft|open|merged|closed> filters.
Addresses unresolved findings from the latest review pass: - Strip quotes from bare title text instead of escaping them, since the backend search-query parser has no backslash-escape handling (DEREM-12). - Add doc comment to normalizeChatSearchInput (DEREM-13). - Rename supportedChatSearchFilterKeys to passthroughChatSearchFilterKeys to clarify why 'title' is excluded (DEREM-16). - Rename hasFallbackTitle to hasBareTitleText (DEREM-19). - Add test for trailing-colon filter behavior (DEREM-17). - Use keepPreviousData to avoid skeleton flash between debounced keystrokes (DEREM-11). - Rename highlightedChatIndex state to selectedChatIndex; rename clamped variable to safeSelectedChatIndex to keep the concept under one name (DEREM-14). - Extract getChatDisplayConfig helper in statusConfig.ts; use in both ChatSearchResults and ChatTreeNode so the icon derivation isn't duplicated (DEREM-10). - Extract RESULTS_AREA_MIN_HEIGHT constant (DEREM-20). - Pluralize result count: '1 result' vs 'N results' (DEREM-18). - Drop the redundant space-y-1 wrapper around the search input (DEREM-21).
Base automatically changed from cian/codagt-432-chat-title-search to main
Resolved conflict in coderd/searchquery/search_test.go by taking main's version. The chat search backend (#25391) is now in main, so the PR branch's older copies of backend files (coderd/searchquery, coderd/exp_chats, coderd/database/queries, coderd/apidoc, docs/reference/api/chats.md) were reset to main's versions to avoid divergence with the merged backend.
jaaydenh
deleted the
jaaydenh/chat-search-frontend
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters