fix: require update permission to recreate devcontainers by sreya · Pull Request #25812 · coder/coder
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Merged
Conversation
The httpmw upstream from this endpoint only checks for read perms to the workspace agent. Recreating a dev container should require update perms since it mutates state. This also matches the behavior of the DELETE endpoint
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks fine, but we should add the reasoning behind the change in the PR description and squash commit message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 participants
