Pass ssh flags to rsync by ammario · Pull Request #21 · coder/sshcode
|
|
||
| flog.Info("syncing extensions") | ||
| err = syncExtensions(host) | ||
| err = syncExtensions(host, *sshFlags) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Args should be flipped.
| `/bin/bash -c 'set -euxo pipefail || exit 1 | ||
| wget -q https://codesrv-ci.cdr.sh/latest-linux -O `+codeServerPath+` | ||
| downloadScript := `/bin/bash -c 'set -euxo pipefail || exit 1 | ||
| wget -q https://codesrv-ci.cdr.sh/latest-linux -O ` + codeServerPath + ` |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why two wget?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea how that got there.. That script is completely broken. We're going to want some tests
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its a good idea we http.Get on our side and then just write the binary to the remote side if it has changed. Would be nice and easy to test as well versus bash scripts.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is the bin is 90MB.
- Also use ssh flags when running the download script Resolves #19