Use Code Insiders by orenc17 · Pull Request #30 · coder/sshcode
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else looks good.
Thank you for the PR, but #34 is easily implemented and will categorically solve this problem.
It's unclear which path to use when both exist. I have VS Code insiders installed right now but I don't actually use it, so this change would silently break sshcode for me.
I think @ammario 's concern can be solved if we keep the selected version to be used in a config file may be.
Should be a good way of handling multiple different version
@SscSPs I'm wary of requiring an additional file just to specify where the configuration dir is. That sounds a bit like a catch 22. Using environment variables, or at the very least CLI flags, would be much cleaner and wouldn't deviate from the standard configuration of code-server or Code.
Imho doing that would be too much cli interaction when our goal is to provide a GUI text editor over SSH...
I think that the people looking for applications like this are the ones who don't like much CLIs, otherwise they would be good with vim/Emacs/nano
Agreed with @foresthoffman that a configuration file is plain overkill.
A selection prompt doesn't feel very unixey to me. Will open a PR for the environment variable solution.
orenc17
changed the title
Use Code Insiders config dir if exists
Use Code Insiders
You can integrate this PR into #39
When the environment variable isn't set you should revert to default which will be chosen using a flag
IMHO the environment variables should be used only if vscode/vscode-insiders is not installed in the default path
closing this to make way for #40