◐ Shell
clean mode source ↗

Use Code Insiders by orenc17 · Pull Request #30 · coder/sshcode

@orenc17

Add a flag for using extensions and settings from VSCode Insiders

scsmithr

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good.

@foresthoffman

@coadler

That seems sensible but this PR is fine on its own. Should make an issue

@ammario

Thank you for the PR, but #34 is easily implemented and will categorically solve this problem.

@coadler

Wouldn't it make sense to have some sane defaults? These two would probably cover most use cases

@ammario

It's unclear which path to use when both exist. I have VS Code insiders installed right now but I don't actually use it, so this change would silently break sshcode for me.

@SscSPs

I think @ammario 's concern can be solved if we keep the selected version to be used in a config file may be.
Should be a good way of handling multiple different version

@foresthoffman

@SscSPs I'm wary of requiring an additional file just to specify where the configuration dir is. That sounds a bit like a catch 22. Using environment variables, or at the very least CLI flags, would be much cleaner and wouldn't deviate from the standard configuration of code-server or Code.

@coadler

We could potentially prompt users if both are found, and remember on consecutive runs

@SscSPs

Imho doing that would be too much cli interaction when our goal is to provide a GUI text editor over SSH...
I think that the people looking for applications like this are the ones who don't like much CLIs, otherwise they would be good with vim/Emacs/nano

@ammario

Agreed with @foresthoffman that a configuration file is plain overkill.

A selection prompt doesn't feel very unixey to me. Will open a PR for the environment variable solution.

@orenc17 orenc17 changed the title Use Code Insiders config dir if exists Use Code Insiders

Apr 22, 2019

@orenc17

@ammario

@orenc17 how do feel about the solution in #39 instead of this?

@orenc17

You can integrate this PR into #39
When the environment variable isn't set you should revert to default which will be chosen using a flag

@ammario

Don't you think that having two ways of doing the same thing is bad UX?

@orenc17

IMHO the environment variables should be used only if vscode/vscode-insiders is not installed in the default path

@orenc17

closing this to make way for #40