Fix #13737 (GUI: should not timeout when premiumaddon takes more than 30 seconds) by danmar · Pull Request #7418 · cppcheck-opensource/cppcheck
CI is fixed - please rebase.
CI is fixed - please rebase.
Thanks!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please separate the crash fix into a different PR.
And did you intend to update the translation files?
And did you intend to update the translation files?
the ts files are updated behind my back whenever I compile the gui. if I am not supposed to commit that then it should be removed from the compilation.
Please separate the crash fix into a different PR.
ok sure.
the ts files are updated behind my back whenever I compile the gui. if I am not supposed to commit that then it should be removed from the compilation.
We had that discussion many times before and I am still waiting on external feedback in #7020 to finally address this.
We had that discussion many times before and I am still waiting on external feedback in #7020 to finally address this
basically I think it would make sense to go ahead with 7020 if that means we won't get ts updates every time we touch the gui. feel free to continue without the feedback.
basically I think it would make sense to go ahead with 7020 if that means we won't get ts updates every time we touch the gui. feel free to continue without the feedback.
Alright. I will do a couple of more tests first so we do not miss something obvious.
