refactor Settings::premium by danmar · Pull Request #7932 · cppcheck-opensource/cppcheck

in my humble opinion I dislike to have duplicated code.

In that case you also need to get rid of the productname being duplicated in the GUI and the settings otherwise this PR would be incomplete. But that requires other changes ... and other changes. And then you get into how we treat the version wrong etc. That's what my changes are about - it will just be incremental since it affects external stuff (i.e. premium).

Paul wants his CMake stuff in (which requires review), you want a MinGW release (which requires lots of changes) and now discussions about a single duplicated line. And all of it is urgent (which it really isn't). And I am actually working on something which allows us to enable something which has never worked since this project existed and has been years in the making. I do not understand these priorities ...

This should just be a three line change. Everything else will be immediately removed when I post my PR.