even more testrunner cleanups by firewave · Pull Request #254 · cppcheck-opensource/simplecpp
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks dangerous. the returned TokenList will reference the local files
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I didn't think about this.
We didn't detect this in Cppcheck - I have this enabled in my IDE and it did not report anything.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I filed https://trac.cppcheck.net/ticket/10975. It is impossible to detect the issue I introduced though since we have no idea what is done with the reference.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.