refs #352 - generate output error on unknown `DUI::std` value by firewave · Pull Request #312 · cppcheck-opensource/simplecpp
If the value is unknown we are silently setting an invalid/unexcepted value for the predefined macros which might lead to other issues.
I guess a simplecpp issue wouldn't hurt also
I guess a simplecpp issue wouldn't hurt also
Good point. Tickets for behavior changes.
I adjusted the code so it uses the OutputList instead of throwing an exception.
Will file a ticket about this later.
bail out on unknown
refs #352 - bail out on unknown DUI::std valueDUI::std value
Will file a ticket about this later.
Done.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, should I merge?
I thought we wanted to make a release with the current state first so we can get this repo and Cppcheck in sync again.
Afterwards feel free to merge anything I made ready for review and you approve of.
refs #352 - bail out on unknown
refs #352 - generate output error on unknown DUI::std valueDUI::std value
I thought we wanted to make a release with the current state first so we can get this repo and Cppcheck in sync again.
Afterwards feel free to merge anything I made ready for review and you approve of.
Sorry.. I have tagged 1.1.3 now. I tagged the old commit e040047
Please feel free to sync cppcheck.
@danmar I changed the title of the PR because we do not actually bail out anymore. Strangely your merge still had the old title. I have no idea how this is even possible!?
Actually it was merge with the original title from when I created this PR. I changed the title multiple times.
I have no seen this in the Cppcheck repo so far but there I usually merge the PRs myself.