fixed #342/fixed #343 - do not treat directories like regular files in existence checks by firewave · Pull Request #339 · cppcheck-opensource/simplecpp
-
Notifications
You must be signed in to change notification settings - Fork 103
Conversation
std::ifstream can open directories and read from them without issue. Nothing will be read though - it is like an empty file. This would have treated an include which actually pointed to a directory as existing (e.g. #include </>).
No tests added since we still do not have tests for additional files ... but I just realized that certain directories always exists so at least on Linux it can be tested.
Moving code is problematic though as Cppcheck is GPL and this would re-license it under 0BSD.
Moving code is problematic though as Cppcheck is GPL and this would re-license it under 0BSD.
After we resolved and merged this we should create another release so we can sync it to Cppcheck.
do not treat directories like regular files in existence checks
fixed #342/#343 - do not treat directories like regular files in existence checks
The helper functions need to be adjusted so they align with the current usage in Cppcheck.
This was referenced
fixed #342/#343 - do not treat directories like regular files in existence checks
fixed #342/fixed #343 - do not treat directories like regular files in existence checks
This was linked to issues
1 participant
