Fix #381 (When there are header files with the same name, the correct file cannot be found) by glankk · Pull Request #443 · cppcheck-opensource/simplecpp
-
Notifications
You must be signed in to change notification settings - Fork 103
Merged
Conversation
The issue is caused by false matches in getFileIdPath, which this fixes. This PR also adds two tests related to path resolution and matching, one for this particular issue of false positives and another one to detect false negatives on case-insensitive systems, which would result in #pragma once breaking. I added them both in this PR because they're related, but I can move the second test to another PR if that's preferable.
Tests are failing due to an unrelated issue in testrunner where the TokenList's in the filedata map aren't destroyed after preprocessing.
Tests are failing due to an unrelated issue in testrunner where the TokenList's in the filedata map aren't destroyed after preprocessing.
I expect that you will look into it and make sure CI is green.
I feel that the testsuite folder should ideally be removed and that we move such tests to python instead.
I've moved the tests to integration_test.py.
2 participants
