Switch to uncrustify by danmar · Pull Request #517 · cppcheck-opensource/simplecpp
@jcfr feel free to review
@jcfr thanks for the reviews. there was some mess in my first commit to cleanup as you saw. but I hope it didn't add any extra changes now.
| # - you can put uncrustify in your PATH | ||
| # - you can create an environment variable UNCRUSTIFY that has the full path of the binary | ||
|
|
||
| UNCRUSTIFY_VERSION="0.72.0" |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I copied the file directly from cppcheck main though. :-( maybe we need to update the script both in cppcheck and simplecpp..
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we need to update the script both in cppcheck and simplecpp..
would you have time to look at that maybe?
The commit should probably have been split as suggested in #517 (review). Indeed, referencing 18cfb6a in .git-blame-ignore-revs will now incorrectly ignore non stylistic changes.
While this is not a critical in the current situation, in the future, I suggest to avoid mixing changes.
This was referenced