◐ Shell
clean mode source ↗

Fixes get pending when body is provided. by etr · Pull Request #166 · etr/libhttpserver

Identify the Bug

As notified in: #165

The webserver hangs the request without terminating if the request is a body-less one (e.g. GET-like) but provides a body.

Description of the Change

This change allows the webserver to process the request without failing.

Alternate Designs

The linked pull-request presents a design that actively parses and processes the body passed in input. This implementation chooses to discard it instead.

Possible Drawbacks

Main drawback of this choice is not to process the body to adhere to a strict semantic (GET not providing a body). This limits use-cases that might require a body to be provided on GET requests. See motivation in the thread here: #165

Verification Process

Unit and Integration tests

Release Notes

Fixed bug that made the webserver hang the request without terminating if the request was a body-less one (e.g. GET-like) but provided a body.