fix: Fix linting and formatting issues by franciscojavierarceo · Pull Request #5907 · feast-dev/feast
- Apply ruff formatting to fix linting issues - Fix line breaking for boolean set value conversion - No functional changes, just code style compliance Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
The issue was that setUp() used a 'with tempfile.TemporaryDirectory()' context manager, which deleted the temporary directory when setUp() finished, but the tests tried to access the SQLite database files later. Changes: - Replace 'with tempfile.TemporaryDirectory()' with 'tempfile.mkdtemp()' - Add proper tearDown() method to clean up temporary directory - Fix indentation after removing the 'with' block This resolves the 'sqlite3.OperationalError: disk I/O error' that was occurring in multiple test methods. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
YassinNouh21 pushed a commit to YassinNouh21/feast that referenced this pull request
* fix: Fix code formatting in type_map.py - Apply ruff formatting to fix linting issues - Fix line breaking for boolean set value conversion - No functional changes, just code style compliance Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com> * fix: Fix SQLite I/O error in OnDemandPythonTransformation tests The issue was that setUp() used a 'with tempfile.TemporaryDirectory()' context manager, which deleted the temporary directory when setUp() finished, but the tests tried to access the SQLite database files later. Changes: - Replace 'with tempfile.TemporaryDirectory()' with 'tempfile.mkdtemp()' - Add proper tearDown() method to clean up temporary directory - Fix indentation after removing the 'with' block This resolves the 'sqlite3.OperationalError: disk I/O error' that was occurring in multiple test methods. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com> * fix: Apply ruff formatting to test file --------- Co-authored-by: Claude Sonnet 4 <noreply@anthropic.com> Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
YassinNouh21 pushed a commit to YassinNouh21/feast that referenced this pull request
* fix: Fix code formatting in type_map.py - Apply ruff formatting to fix linting issues - Fix line breaking for boolean set value conversion - No functional changes, just code style compliance Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com> * fix: Fix SQLite I/O error in OnDemandPythonTransformation tests The issue was that setUp() used a 'with tempfile.TemporaryDirectory()' context manager, which deleted the temporary directory when setUp() finished, but the tests tried to access the SQLite database files later. Changes: - Replace 'with tempfile.TemporaryDirectory()' with 'tempfile.mkdtemp()' - Add proper tearDown() method to clean up temporary directory - Fix indentation after removing the 'with' block This resolves the 'sqlite3.OperationalError: disk I/O error' that was occurring in multiple test methods. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com> * fix: Apply ruff formatting to test file --------- Co-authored-by: Claude Sonnet 4 <noreply@anthropic.com> Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
jyejare pushed a commit to opendatahub-io/feast that referenced this pull request
* fix: Fix code formatting in type_map.py - Apply ruff formatting to fix linting issues - Fix line breaking for boolean set value conversion - No functional changes, just code style compliance Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com> * fix: Fix SQLite I/O error in OnDemandPythonTransformation tests The issue was that setUp() used a 'with tempfile.TemporaryDirectory()' context manager, which deleted the temporary directory when setUp() finished, but the tests tried to access the SQLite database files later. Changes: - Replace 'with tempfile.TemporaryDirectory()' with 'tempfile.mkdtemp()' - Add proper tearDown() method to clean up temporary directory - Fix indentation after removing the 'with' block This resolves the 'sqlite3.OperationalError: disk I/O error' that was occurring in multiple test methods. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com> * fix: Apply ruff formatting to test file --------- Co-authored-by: Claude Sonnet 4 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters