◐ Shell
clean mode source ↗

Add more validation in feature spec registration by pradithya · Pull Request #11 · feast-dev/feast

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@pradithya

Copy link Copy Markdown

Collaborator

Add validation in feature spec registration to prevent users from registering feature that uses unsupported storage.

@pradithya pradithya requested review from woop and zhilingc

December 20, 2018 11:26

@woop woop left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhilingc zhilingc left a comment

Copy link Copy Markdown

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~

@zhilingc zhilingc merged commit 3b17d7a into master

Dec 24, 2018

@zhilingc zhilingc deleted the feature_spec_validation branch

December 24, 2018 13:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop approved these changes

@zhilingc zhilingc zhilingc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pradithya @woop @zhilingc