fix: Remove bad snowflake offline store method by sfc-gh-madkins · Pull Request #3204 · feast-dev/feast
Signed-off-by: Miles Adkins miles.adkins@snowflake.com
What this PR does / why we need it:
Removes faulty retrieval method that doesnt incorporate on-demand feature views
Which issue(s) this PR fixes:
Fixes #
Signed-off-by: Miles Adkins <miles.adkins@snowflake.com>
to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.70%. Comparing base (c19d640) to head (a5a0e1b).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@ ## master #3204 +/- ## ========================================== + Coverage 67.02% 75.70% +8.68% ========================================== Files 175 211 +36 Lines 15940 17919 +1979 ========================================== + Hits 10683 13566 +2883 + Misses 5257 4353 -904
| Flag | Coverage Δ | |
|---|---|---|
| integrationtests | 66.86% <ø> (-0.16%) |
⬇️ |
| unittests | 57.91% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: felixwang9817, sfc-gh-madkins
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:OWNERS[felixwang9817]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment