fix: Fix handling of TTL in Go server by wdhorton · Pull Request #3232 · feast-dev/feast
Which issue(s) this PR fixes:
According to the FeatureView docstring, 'A ttl of 0 indicates that this group of features lives forever.' However, the Go feature server doesn't currently respect this, returning OUTSIDE_MAX_AGE for FeatureViews that have a TTL of 0. This fixes that issue by always returning false for checkOutsideTtl if the TTL is 0.
According to the FeatureView docstring, 'A ttl of 0 indicates that this group of features lives forever.' However, the Go feature server doesn't currently respect this, returning OUTSIDE_MAX_AGE for FeatureViews that have a TTL of 0. This fixes that issue by always returning false for checkOutsideTtl if the TTL is 0. Signed-off-by: William Horton <william.horton@grandrounds.com>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.87%. Comparing base (e117082) to head (bd2c94c).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@ ## master #3232 +/- ## ========================================== + Coverage 67.48% 76.87% +9.38% ========================================== Files 179 213 +34 Lines 16370 18076 +1706 ========================================== + Hits 11048 13896 +2848 + Misses 5322 4180 -1142
| Flag | Coverage Δ | |
|---|---|---|
| integrationtests | 67.31% <ø> (-0.17%) |
⬇️ |
| unittests | 58.26% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: achals, adchia, wdhorton
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Details
Needs approval from an approver in each of these files:OWNERS[achals,adchia]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment